fix(#501): remove redundant info from code agent PR body - #521

Site preview

Preview: https://c219f224-site.fullsend-ai.workers.dev

Commit: 19a6b806adc24381aac90d29886fcb45f2246e1c

Review: #521

Head SHA: 19a6b80
Timestamp: 2026-04-29T12:30:00Z
Outcome: comment-only

Summary

The change correctly addresses all three items in issue #501: deduplicating the Closes #N reference (by stripping Closes # lines from the commit body before the PR body template adds its own canonical footer reference), removing the redundant Changed files section, and removing the Created by attribution line. The production code changes are minimal, safe, and well-scoped. The tests cover the right assertions (single Closes line, no Changed files, no Created by, fallback text) but have a structural gap: they reimplement the assembly logic in a separate build_pr_body function rather than exercising the actual post-code.sh code path, so the key sed '/^Closes #/d' stripping is not verified.

Findings

Medium

• [Correctness / Test adequacy] post-code-test.sh:125-250 — The build_pr_body test helper reimplements the PR body template from scratch rather than testing the actual post-code.sh code. The critical deduplication fix (sed '/^Closes #/d' on line 186 of post-code.sh) is therefore never exercised by any test. The count_closes_test cases pass commit bodies that don't contain Closes #, so they verify the template has one Closes line, but not that a duplicate is stripped. Consider adding a test case where the commit body includes a Closes #42 line and asserting the output still contains exactly one.

  Remediation: Add a count_closes_test case with a commit body like "Fix rendering bug.\n\nCloses #42" and verify the count is still 1. Ideally, also consider sourcing or invoking the relevant section of post-code.sh rather than reimplementing it, so the test exercises the actual sed pipeline.

Low

• [Style/conventions] post-code.sh:186 — The sed pipeline now chains three separate sed invocations. These could be consolidated into a single sed call with multiple -e expressions for readability: sed -e '/^Signed-off-by:/d' -e '/^Closes #/d' -e :a -e '/^\n*$/{ $d; N; ba; }'. Minor — no functional impact.

Info

• [Intent alignment] The PR description itself exhibits the very duplication being fixed (two Closes #501 lines, a Changed files section, and a Created by footer). This is expected — the PR was created by the pre-fix version of the script — and serves as a live example of the problem.

Footer

Outcome: comment-only
This review applies to SHA 19a6b806adc24381aac90d29886fcb45f2246e1c. Any push to the PR head clears this review and requires a new evaluation.